[19.0][MIG] product_pricelist_revision: Migration to 19.0#2100
[19.0][MIG] product_pricelist_revision: Migration to 19.0#2100BhaveshHeliconia wants to merge 28 commits intoOCA:19.0from
Conversation
|
/ocabot migration product_pricelist_revision |
gdgellatly
left a comment
gdgellatly
left a comment
There was a problem hiding this comment.
Functional test on own db plus code review LGTM.
gdgellatly
left a comment
gdgellatly
left a comment
There was a problem hiding this comment.
Sorry I put review against wrong module. I now tested this one on live database and it didn't work. It duplicated the item just fine but did not take the variance. Will get back to tomorrow.
[UPD] Update product_pricelist_revision.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-12.0/product-attribute-12.0-product_pricelist_revision Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_pricelist_revision/
…t filter TT28144 [UPD] Update product_pricelist_revision.pot
Currently translated at 100.0% (30 of 30 strings) Translation: product-attribute-13.0/product-attribute-13.0-product_pricelist_revision Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_pricelist_revision/ca/
Before this change on runbot we caught a Warning about deprecated call to decimal_precision.get_precision(<application>) [UPD] README.rst product_pricelist_revision 13.0.1.1.0
Fix website key in the manifests
Currently translated at 31.0% (9 of 29 strings) Translation: product-attribute-14.0/product-attribute-14.0-product_pricelist_revision Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_pricelist_revision/it/
Currently translated at 100.0% (29 of 29 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_revision Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_revision/it/
- Include context keys for avoiding mail operations overhead.
Currently translated at 100.0% (29 of 29 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_revision Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_revision/fr/
BhaveshHeliconia
force-pushed
the
19.0-mig-product_pricelist_revision
branch
from
1b96722 to
68cfb1b
Compare
Hi @gdgellatly, I have tested this module locally and on Runbot, and it is working as expected. Please note that this module's duplicate wizard only works with fixed price items (compute_price = 'fixed'). It does not apply the variance for other pricing types such as formula or percentage/discount. The wizard view also mentions this: "Note: Only works with fixed price items. The variation % will be applied to calculate the new price." If you are facing any issue specifically with fixed price items, could you please elaborate on the steps to reproduce and where exactly you are getting stuck? That would help us investigate further. |
Hi @BhaveshHeliconia, yes sorry we worked that out and deleted the module. We have no use case for it so will remove my review. EDIT: I no longr have access to remove reviews so we will just have to live with it, it did work, just not how expected. |
18 participants
No description provided.